-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pyproject file for project metadata. #1865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change and a few suggestions for follow on PRs
@@ -78,14 +78,14 @@ Ready to contribute? Here's how to set up _geemap_ for local development. | |||
5. When you're done making changes, check that your changes pass flake8 and the tests, including testing other Python versions with tox: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for the commit, but setting up https://github.com/pre-commit/pre-commit or simillar would be a good idea to automate this kind of cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Good idea!
readme = "README.rst" | ||
requires-python = ">=3.8" | ||
keywords = [ | ||
"geemap", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for here, but the keyword list needs to be expanded
authors = [ | ||
{name = "Qiusheng Wu", email = "giswqs@gmail.com"}, | ||
] | ||
classifiers = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for here, but the classifiers needs to be expanded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naschmitz Great work! I have many Python packages that also need the migration. This is a great example I can learn from. Thank you very much!
@naschmitz I just realized that the wheel generated by |
Motivation:
Summary of changes:
bumpversion
withbump-my-version
.flake8
withpflake8
.