Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdsfactory8 #396

Merged
merged 17 commits into from
Jul 15, 2024
Merged

Gdsfactory8 #396

merged 17 commits into from
Jul 15, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jul 12, 2024

update to gdsfactory8

Copy link
Contributor

sourcery-ai bot commented Jul 12, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 13, 2024
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 87.19512% with 21 lines in your changes missing coverage. Please review.

Project coverage is 68.69%. Comparing base (84d647f) to head (9cdcb81).

Files Patch % Lines
ubcpdk/components.py 87.06% 15 Missing ⚠️
ubcpdk/import_gds.py 90.32% 3 Missing ⚠️
ubcpdk/tech.py 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   69.31%   68.69%   -0.62%     
==========================================
  Files          19       19              
  Lines         756      722      -34     
==========================================
- Hits          524      496      -28     
+ Misses        232      226       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 5ceaa2d into main Jul 15, 2024
8 of 9 checks passed
@joamatab joamatab deleted the gdsfactory8 branch July 15, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant