Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output highlighting for non-classic themes #910

Conversation

sergio-calvo-devo
Copy link

The text highlighting has some problems with themes other than the classic one. There are two overlapping texts and the result is illegible.
imagen

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2019

CLA assistant check
All committers have signed the CLA.

@d98762625
Copy link
Member

d98762625 commented May 27, 2020

Hello, thanks a lot for your PR.

I have been able to replicate this issue and can confirm that your PR stops the additional text from being show when you disable the to base64 operation. For the record I took these steps:

  • add To Base64 operation
  • add some input text
  • highlight some of the input text (which also highlights some output chars)
  • disable the operation
  • see the overlapping text

When trying out your change, I can see that the "old" output is not visible, but the highlight it still highlighting where the "old" characters should be. This changes when you move the cursor off the operation panel in the UI (just like how the original issue resolves itself if you unfocus)

I think this new behaviour is more dangerous than the original, because the highlight looks OK, but it is not what should be highlighted.

To approve this, I would like to see the actual highlight be updated upon pressing the 'disable' button on the To Base64 operation

@a3957273
Copy link
Member

a3957273 commented Apr 2, 2024

The previous comments on this PR haven't been resolved and we're now 4 years on, so I'm going to close this ticket as stale. If you have time in the future to update this, feel free to open a new PR :)

@a3957273 a3957273 closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants