Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Advanced Entropy #535

Merged
merged 11 commits into from
Jun 28, 2019
Merged

Conversation

MShwed
Copy link
Contributor

@MShwed MShwed commented Apr 7, 2019

Addresses #453

Adds entropy visualizations:

  • Image
  • Curve
  • Histogram (Line)
  • Histogram (Bar)

I moved this to a separate operation but this could easily be added to the existing "Entropy" operation.
Each of these visualizations could also be their own operation with associated arguments for customization.

For large files when the operation returns an svg, the input/output threshold would need to be increased by the user otherwise the Dish _translate function attempts to escape html content when converting data to an intermediate buffer leaving the output file 0 bytes.

I'm open to adding other visualizations or re-working current ones if need be.

Samples

Image

Screen Shot 2019-04-06 at 11 11 49 PM

Curve

Screen Shot 2019-04-06 at 11 33 09 PM

Histogram (Line)

Screen Shot 2019-04-06 at 11 11 34 PM

Histogram (Bar)

Screen Shot 2019-04-06 at 11 34 54 PM

@n1474335
Copy link
Member

This is brilliant. I think this should be added to the current 'Entropy' operation though, rather than being a separate op.

@MShwed
Copy link
Contributor Author

MShwed commented Jun 27, 2019

Awesome, I moved this under the 'Entropy' Operation. The previous behaviour is preserved under the 'Shannon' visualization

Screen Shot 2019-06-27 at 2 21 27 PM

@n1474335 n1474335 merged commit b0b6de1 into gchq:master Jun 28, 2019
@n1474335
Copy link
Member

Great stuff, thanks very much. I made a few improvements to the efficiency so this can now process large files significantly faster. The visualisations are really nice.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants