Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JWT Verify, Decode and Sign Operators #348

Merged
merged 2 commits into from
Aug 31, 2018
Merged

Add JWT Verify, Decode and Sign Operators #348

merged 2 commits into from
Aug 31, 2018

Conversation

GCHQ77703
Copy link
Member

Having some trouble designing tests for these, due to the creation of an iat token within the JSON response that represents the time that the token was created at. Ideas are welcome.

@n1474335
Copy link
Member

You probably want to be using an option argument rather than a populateOption. See my comment in #347.

@GCHQ77703
Copy link
Member Author

GCHQ77703 commented Aug 29, 2018

Fixed the tests, found I can just force the iat value to whatever I want. Due to library limitations, it appears that the verification of ES and RS signature schemes are broken so they have been disabled. Decoding / encoding to those types still works.

Also fixed the option issue, thanks for helping out!

@n1474335 n1474335 merged commit a95f43a into gchq:master Aug 31, 2018
@n1474335
Copy link
Member

Awesome work, thanks very much. I made a few changes to improve error handling and the descriptions.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants