Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress: Add PGP operations using kbpgp #206

Merged
merged 11 commits into from
Mar 28, 2018

Conversation

tlwr
Copy link
Contributor

@tlwr tlwr commented Nov 25, 2017

Continuation of #195 but using kbpgp instead of openpgpjs based on discussion in Gitter.

kbpgp has been a bit easier to work with and supports ECC.

Here is an initial spike of just one operation: "Generate PGP Key Pair".

@artemisbot I'd like to collaborate with you on this.

As of yet I have not yet found a nice way of working with the kbpgp API as it is
very callback heavy. Probably just my rusty javascript.

image

Have not yet found a nice way of working with the kbpgp API as it is
very callback heavy. Probably just my rusty javascript.
@mattnotmitt
Copy link
Collaborator

I've started using es6-promisify in parallel with this to make it neater and not callback hell.

tlwr and others added 8 commits December 23, 2017 17:33
Currently the encrypt operation works only to my public key and not to
keys generated by the generate key pair operation. Probably something
wrong with the generate operation.
@n1474335 n1474335 merged commit aa3f781 into gchq:master Mar 28, 2018
@n1474335
Copy link
Member

Awesome work @tlwr and @artemisbot. I know this one has been around for a while, but it's been worth the wait. Thanks for your efforts.

BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
[FEATURE] Multi-Search with Custom Bangs
Fixes gchq#206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants