Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated bcrypt library to resolve compatibility issue (#1853) #1857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Updated bcrypt library to resolve compatibility issue (#1853) #1857

wants to merge 1 commit into from

Conversation

shivansh84ya
Copy link

fix: Updated bcrypt library to resolve compatibility issue (#1853)

  • Updated the bcrypt library to the latest version to support hashes beginning with '$2b'.
  • Implemented changes to ensure backward compatibility with existing hashes.
  • Verified functionality using the provided test case with 'Bcrypt compare' in CyberChef.

Resolves: #1853

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shivansh84ya shivansh84ya mentioned this pull request Jul 6, 2024
Open
jonycoo
jonycoo suggested changes Jul 6, 2024
View reviewed changes
Copy link

@jonycoo jonycoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the failing Test, the BcryptCompare.mjs has not been changed to the new Library.
The other Error: failing to find index.mjs
does not seem to come directly from the changes, it may be a secondery side-effect from the first one.

@shivansh84ya
Copy link
Author

@jonycoo
I will investigate this more and address these issues before resubmitting the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonycoo jonycoo jonycoo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug report: bcrypt version old
3 participants
@shivansh84ya @CLAassistant @jonycoo