Add support for ECDSA and DSA keys CSR to Parse CSR operation #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robinsandhu
force-pushed
the
feat/support-other-keys-in-parse-csr
branch
from
9691851
to
ae03e34
Compare
a3957273
reviewed
Jun 11, 2024
src/core/operations/ParseCSR.mjs
Outdated
| if (extension.msSGC) usage.push("Microsoft Server Gated Crypto"); | ||
| if (extension.msEFS) usage.push("Microsoft Encrypted File System"); | ||
| if (extension.nsSGC) usage.push("Netscape Server Gated Crypto"); | ||
| const ekuIdentifierToName = new Map([ |
There was a problem hiding this comment.
What's the advantage of using a map here, over a simple object?
There was a problem hiding this comment.
Nothing really, refactored the code to use Object instead.
|
Woah, this is some really impressive work! I'm going to need to find some time to really properly review this, as it's a rather major change to one of our fundamental operations. A quick once-over doesn't suggest any major issues. Just one query above about your usage of |
a3957273
approved these changes
Jun 21, 2024
|
Thanks Robin! This is an amazing PR to improve our CSR parsing capabilities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
Parse CSRoperation to use jsrsasign package instead of node-forge for parsing CSR's because with current package this operation is limited to CSRs with RSA keys. With the changes in this PR,Parse CSRnow supports parsing CSRs with ECDSA and DSA keys.I have also updated the output format of this operation, which mainly includes removing the
Versionfield and re-ordering some sections of the CSR attributes and extensions in the output box.Side Effect
Unfortunately I couldn't find any way to parse version number from the CSRs, but I feel that can be considered as an acceptable trade-off since there's only one universally used value for that field i.e. 0 defined in RFC#2986.
Type of change
Please select the option that best describes the change:
How Has This Been Tested?
Tested locally on my machine with various CSRs. Following are some outputs from those tests:
Checklist: