Improving efficency of RAKE #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sw5678 , could you resolve the trailing space errors? I realise they weren't introduced in your commit. |
a3957273
requested changes
Mar 29, 2024
src/core/operations/RAKE.mjs
Outdated
| }); | ||
| }); | ||
| const wordDegreeMatrix = Array(tokens.length).fill().map(() => Array(tokens.length).fill(0)); | ||
| for (let p=0; p < phrases.length; p++) { |
There was a problem hiding this comment.
You can improve the readability of this by using 'for of' loops instead of dealing with index loops:
for (let phrase of phrases) {
for (let word1 of phrase) {
for (let word2 of phrase) {
wordDegreeMatrix[tokens.indexOf(word1)][tokens.indexOf(word2)]++;
}
}
}
This is the best of both worlds, the improved readability of forEach without sacrificing the 50% reduction in performance.
There was a problem hiding this comment.
Sorry have only just seen this now. Ill make the changes.
|
Very nice improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes too the method to make it more efficient from the PR comments.