Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - Aria labels for buttons #1743

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

e218736
Copy link
Contributor

@e218736 e218736 commented Feb 29, 2024

Issue
Issue #1718

This PR aims to solve some of the 'inconsistent button labels' outlined in item 2 of Screen reader in the issue linked above. E.g. Buttons with material-icons are announced by the screen reader as the icons inner text. The announcement is often not indicative of the action performed by the button and can include announcements of 'underscore'.

Code changes:

  • aria hidden applied to inner icon elements of button so that text isn't announced by screen reader
  • Aria labels added to buttons which are descriptive of functionality

User-facing changes:

  • None visible
  • Screen reader announces descriptive aria labels on button focus

To replicate:

  • With a screen reader active Tab to buttons above recipe/input/output and favourites button
  • Expect screen reader to announce appropriate button functionality rather than icon titles

@e218736 e218736 marked this pull request as ready for review March 5, 2024 13:55
@a3957273 a3957273 merged commit b2e400f into gchq:master Apr 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants