Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding and removing tests #1714

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Adding and removing tests #1714

merged 1 commit into from
Feb 12, 2024

Conversation

sw5678
Copy link
Member

@sw5678 sw5678 commented Feb 12, 2024

I realised my File Tree test was not running so I have added it so that it runs.

I also did a clean up of the test to:

  • remove the old ones (the functionality was no in CC anymore):
    • tests/operations/tests/ToGeohash.mjs
    • tests/operations/tests/FromGeohash.mjs
  • Add tests that were no being run:
    • tests/operations/tests/LuhnChecksum.mjs
    • tests/operations/tests/ConvertToNATOAlphabet.mjs
    • tests/operations/tests/FileTree.mjs

I also put the test imports into alphabetical order to make it easier to add in new imports.

@a3957273
Copy link
Member

Whoops, that's a fun thing to add to my list of things to review in PRs. Gotta make sure the tests are actually included!

@a3957273 a3957273 merged commit fc7c631 into gchq:master Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants