Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pad rail fence decode fixes #1069 #1071

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Don't pad rail fence decode fixes #1069 #1071

merged 2 commits into from
Feb 1, 2021

Conversation

maqifrnswa
Copy link
Contributor

The rail fence decode algorithm works without padding. Adding padding incorrectly decrypts strings. See #1069

@mt3571 mt3571 mentioned this pull request Feb 1, 2021
Closed
@mt3571
Copy link
Contributor

mt3571 commented Feb 1, 2021

This also fixes #1163.

@n1474335 n1474335 merged commit 1baea1d into gchq:master Feb 1, 2021
@alblue
Copy link
Contributor

alblue commented Feb 2, 2021

This fixes the problem in the linked issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maqifrnswa @mt3571 @alblue @n1474335 @n1073645