Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Unneccesary use of vkbeautify contradicts design principles #462

Closed
ghost opened this issue Dec 31, 2018 · 1 comment
Closed

Misc: Unneccesary use of vkbeautify contradicts design principles #462

ghost opened this issue Dec 31, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Dec 31, 2018

Summary

Quite a few operations use vkbeautify to perform their actions. Most of these operations could be done with their own code.
One of the Design Principles of CyberChef is to keep it Standalone and I think that these operations should be rewritten to avoid unnecessarily using the library.

Example

@n1474335
Copy link
Member

n1474335 commented Jan 1, 2019

The vkbeautify library is pretty small. Since we use every feature it provides, it seems like a reasonable inclusion. If we were to rewrite each of these operations ourselves, we likely wouldn't actually end up with any less code overall. Obviously we would have more control over it, so I'm not against this, but it's not a high priority at the moment.

I'll close this issue for now, but if anyone would like to submit a PR which replaces vkbeautify with bespoke code, I'll happily take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant