Updated review wording for new access requests and releases #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR40159
requested changes
Aug 21, 2024
| @@ -37,11 +37,11 @@ export async function requestReviewForRelease(entity: string, review: ReviewDoc, | |||
| } | |||
|
|
|||
| const emailContent = buildEmail( | |||
| `Release ${release.semver} has been created for model ${release.modelId}`, | |||
| `Release ${release.semver} for model ${release.modelId} is ready for your review`, | |||
There was a problem hiding this comment.
Under a previous ticket, BAI-1383, all emails that require a user to do something should now have ""ACTION REQUIRED:" prepended to the subject?
| @@ -68,11 +72,10 @@ export async function requestReviewForAccessRequest( | |||
| } | |||
|
|
|||
| const emailContent = buildEmail( | |||
| `Request for Entities '${accessRequest.metadata.overview.entities}' access to the model '${accessRequest.modelId}'`, | |||
| `${requestingEntitiesText(accessRequest.metadata.overview.entities.length)} requesting access to model ${accessRequest.modelId}`, | |||
There was a problem hiding this comment.
I'm assuming you've done this because the raw list of entities isn't nice to look at. Normally I'd suggest using getUserInformation() so convert them all to friendly name but here we might have both users and groups. How do we present groups nicely in the frontend if we don't have a group equivalent for getUserInformation()?
JR40159
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.