Use accordions for schema selection, hiding inactive schemas by default #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing inactive schemas during selection could confuse some users, especially if an organisation is trying to encourage the use of active schemas only. This change makes both active and inactive schemas appear within accordions, with active schemas shown expanded by default. Users can still expand and select an inactive schema if desired, but it's a conscious choice.
The accordion styling props is configured to remove the divider that's shown only when collapsed, and also ensure that the expand icon is justified-right all the time. If the active/inactive schema accordion is empty (no schemas) it would be misaligned with the other accordion.