Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added run to time feature #478

Merged
merged 9 commits into from
Feb 2, 2021
Merged

Added run to time feature #478

merged 9 commits into from
Feb 2, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Dec 9, 2020

Add the ability to set a run-to-time. This will allow a user to set the simulation time that simulation should run to and then pause.

Requires gazebosim/gz-msgs#108.

Signed-off-by: Nate Koenig nate@openrobotics.org

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Dec 9, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the use case for this feature that couldn't be handled by the user through the multi_step field?

I also have a concern on bumping the major version of ign-msgs and ign-transport for Edifice just for this feature. Are there more changes planned to those libraries to help justify the new versions?

CMakeLists.txt Outdated Show resolved Hide resolved
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Dec 17, 2020
src/SimulationRunner.cc Show resolved Hide resolved
src/SimulationRunner.cc Outdated Show resolved Hide resolved
@nkoenig
Copy link
Contributor Author

nkoenig commented Dec 21, 2020

Could you explain the use case for this feature that couldn't be handled by the user through the multi_step field?

I also have a concern on bumping the major version of ign-msgs and ign-transport for Edifice just for this feature. Are there more changes planned to those libraries to help justify the new versions?

In order to step to a simulation time, I would need to know the step size. This can be accomplished, but it's not user friendly especially from the command line.

@chapulina
Copy link
Contributor

Since we're bumping the ign-msgs dependency, that will need to be done before this can be merged: gazebo-tooling/release-tools#362

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig changed the base branch from main to ign-gazebo5 December 23, 2020 23:34
@chapulina chapulina changed the base branch from ign-gazebo5 to main January 5, 2021 00:29
Signed-off-by: Louise Poubel <louise@openrobotics.org>
examples/worlds/fuel.sdf Outdated Show resolved Hide resolved
src/SimulationRunner.cc Show resolved Hide resolved
src/SimulationRunner.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #478 (adf8aa4) into main (6166234) will decrease coverage by 0.02%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   77.38%   77.35%   -0.03%     
==========================================
  Files         213      213              
  Lines       11950    11970      +20     
==========================================
+ Hits         9247     9259      +12     
- Misses       2703     2711       +8     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/World.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Factory.hh 96.05% <ø> (ø)
...e/ignition/gazebo/detail/EntityComponentManager.hh 95.00% <ø> (ø)
include/ignition/gazebo/gui/GuiRunner.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiSystem.hh 0.00% <ø> (ø)
include/ignition/gazebo/gui/TmpIface.hh 0.00% <ø> (ø)
src/Server.cc 82.80% <ø> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780490f...0a70940. Read the comment docs.

Nate Koenig added 4 commits January 29, 2021 08:47
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jan 30, 2021
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me when a new Msgs release is ready.

@chapulina
Copy link
Contributor

Looks good to me when a new Msgs release is ready.

This should be ok, the CI errors are coming from other things.

@nkoenig nkoenig merged commit d50aceb into main Feb 2, 2021
@nkoenig nkoenig deleted the nkoenig/run_to_time branch February 2, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants