Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump in Edifice: msgs7 and transport10 #362

Closed
chapulina opened this issue Dec 14, 2020 · 3 comments
Closed

Bump in Edifice: msgs7 and transport10 #362

chapulina opened this issue Dec 14, 2020 · 3 comments
Assignees

Comments

@chapulina
Copy link
Contributor

Bump edifice to use ign-msgs7 and ign-transport10.

The script in #333 should be helpful.

#331 may also be a helpful reference.

@iche033
Copy link
Contributor

iche033 commented Jan 9, 2021

just noticed that edifice uses ignition-fuel_tools5 which pulls in ignition-msgs6. We may need to consider also bumping edifice to use ignition-fuel_tools6 and update its msgs dependency to 7

hmm looks like the msgs7 bump has been done in a branch in ign-gui and ign-sensors already

@chapulina chapulina assigned chapulina and unassigned nkoenig Jan 11, 2021
@chapulina
Copy link
Contributor Author

All PRs needed to bump to ign-msgs7, and consequently ign-transport10 and ign-fuel-tools6, are open and referenced above.

I opened them using the script from #333 and some manual cleanup. The manual cleanup was needed mainly on the homebrew-simulation PRs.

Most of these PRs will need to be merged at the same time, so we don't end up in a broken state.

@chapulina
Copy link
Contributor Author

chapulina commented Jan 12, 2021

Order:

  • Merge docs
  • Merge new homebrew formulae
  • Merge dep bumps in homebrew, release-tools and gazebodistro
  • Trigger new CI for ign-transport and ign-fuel-tools
  • Merge ign-transport and ign-fuel-tools source code
  • Trigger new CI for ign-gui and ign-sensors
  • Merge ign-gui and ign-sensors source code
  • Trigger new CI for ign-gazebo and ign-launch
  • Merge ign-gazebo and ign-launch source code
  • Merge ign-edifice source code
  • Merge all -release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants