Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ign-gazebo3 homebrew build regression (#1661) #1663

Closed
wants to merge 1 commit into from

Conversation

Blast545
Copy link
Contributor

Attempt to address cmakelist problems

Signed-off-by: Crola1702 j.arroyo@uniandes.edu.co
Signed-off-by: Crola1702 j.arroyo@uniandes.edu.co

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Crola1702 <j.arroyo@uniandes.edu.co>

Signed-off-by: Crola1702 <j.arroyo@uniandes.edu.co>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1663 (7d90f68) into ign-gazebo3 (873b43b) will not change coverage.
The diff coverage is n/a.

❗ Current head 7d90f68 differs from pull request most recent head da2e5ae. Consider uploading reports for the commit da2e5ae to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo3    #1663   +/-   ##
============================================
  Coverage        77.98%   77.98%           
============================================
  Files              255      255           
  Lines            15041    15041           
============================================
  Hits             11729    11729           
  Misses            3312     3312           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters
Copy link
Member

I think the problem is in ign-sensors3: gazebosim/gz-sensors#262

@chapulina
Copy link
Contributor

Closing in favor of gazebosim/gz-sensors#262

@chapulina chapulina closed this Aug 27, 2022
@chapulina chapulina deleted the crola_1702/fix_cmakelists_aug_2022 branch August 27, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel macOS macOS support
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants