Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DEPENDS_ON_COMPONENTS parameters #262

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes homebrew build of ign-gazebo3 osrf/homebrew-simulation#2008, alternative to gazebosim/gz-sim#1663

Summary

The ign-gazebo3 builds have been failing since ign-sensors 3.4.0 was released (see osrf/homebrew-simulation#2008 (comment)).

From the cmake output:

-- Searching for dependencies of ignition-sensors3-gpu_lidar
...
  Found package configuration file:

    /usr/local/lib/cmake/ignition-sensors3-gpu_lidar/ignition-sensors3-gpu_lidar-config.cmake

  but it set ignition-sensors3-gpu_lidar_FOUND to FALSE so package
  "ignition-sensors3-gpu_lidar" is considered to be NOT FOUND.  Reason given
  by package:

  The following imported targets are referenced, but are missing:
  ignition-sensors3::ignition-sensors3-lidar
...
-- Looking for ignition-sensors3 - not found

There are some component libraries that link to other component libraries but they also need to declare those dependencies with the DEPENDS_ON_COMPONENTS parameter to ign_add_component (see gz-physics/dartsim for example). This adds all the missing DEPENDS_ON_COMPONENTS calls that I could see, and fixes the ign-gazebo3 build in my local testing.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This is needed to fix ign-gazebo3 builds.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #262 (6d96ee9) into ign-sensors3 (197ea8d) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           ign-sensors3     #262   +/-   ##
=============================================
  Coverage         77.57%   77.57%           
=============================================
  Files                23       23           
  Lines              2377     2377           
=============================================
  Hits               1844     1844           
  Misses              533      533           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Blast545
Copy link
Contributor

Known warnings on windows-pr, otherwise all CI green, ready to merge 👍

FYI: @Crola1702

@scpeters scpeters merged commit c754e21 into ign-sensors3 Aug 26, 2022
@scpeters scpeters deleted the scpeters/depends_on_component branch August 26, 2022 22:08
scpeters added a commit to osrfbuild/homebrew-simulation that referenced this pull request Aug 26, 2022
Patch from part of gazebosim/gz-sensors#262,
needed by ignition-gazebo3.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to osrf/homebrew-simulation that referenced this pull request Aug 27, 2022
* ignition-sensors3: add patch

Patch from part of gazebosim/gz-sensors#262,
needed by ignition-gazebo3.

* update  bottle.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants