Refactor common sensor setup interactions #1471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
8 tasks
mjcarroll
added a commit
that referenced
this pull request
Jul 21, 2022
Split from #1471 to address force-torque sensor incrementally. Partially addresses #797 Not all sensor system implementations were updated as part of #1281, one of which being the ForceTorqueSensor. This makes the reset behavior incorrect and the sensor won't be respawned. Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug uncovered when using the
Resetimplementation with theForceTorqueSensor.Not all sensor system implementations were updated as part of #1281, one of which being the
ForceTorqueSensor. This makes the reset behavior incorrect and the sensor won't be respawned.As part of this, I'm also experimenting with refactoring out the common functionality that is boilerplate in any GzSensors system implementation. To view the diff for a single system that was already updated, see 20b15b6
Once complete, this should close out: #797 as all sensors will be updated.