Don't save segmentation data by default in the example world #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
chapulina
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashton Larkin ashton@openrobotics.org
Summary
When we merged #853, the segmentation cameras in the example world (
examples/worlds/segmentation_camera.sdf) save data by default. This could result in saving a lot of data if simulations are run for a long time, and saving data also hurts simulation runtime performance (see gazebosim/gz-sensors#158). So, I think it's better to not save segmentation data by default, and to let users opt in to this if they want to.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge