Set custom projection matrix based on intrinsics params from SDF #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## gz-sensors7 #293 +/- ##
===============================================
+ Coverage 71.66% 71.85% +0.19%
===============================================
Files 37 37
Lines 4665 4690 +25
===============================================
+ Hits 3343 3370 +27
+ Misses 1322 1320 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
note that we've also added |
|
yeah I saw that. I can add that in once #289 is merged. |
sounds great; thanks |
ahcorde
requested changes
Dec 1, 2022
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
ahcorde
approved these changes
Dec 2, 2022
9 tasks
iche033
added a commit
that referenced
this pull request
Feb 14, 2023
This PR allows users to specify custom camera projection using the <projection> values from SDF (in addition to <instrinscs>, see #293). Also bumped sdformat dep version as it need gazebosim/sdformat#1203 --------- Signed-off-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
pushed a commit
that referenced
this pull request
Sep 13, 2023
Closes #288 This PR extends the camera sensor functionality to support custom projection matrix based on input instrinics values. Specifically, it reads the lens <instrinsics> params from SDF, builds the projection matrix from the input values using code ported from Gazebo-classic, and set the camera to use this custom projection matrix. Expanded the camera intrinsics integration test to compare image output from cameras with different intrinsics values. Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #288
Summary
This PR extends the camera sensor functionality to support custom projection matrix based on input instrinics values. Specifically, it reads the lens
<instrinsics>params from SDF, builds the projection matrix from the input values using code ported from Gazebo-classic, and set the camera to use this custom projection matrix.Expanded the camera intrinsics integration test to compare image output from cameras with different intrinsics values.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.