Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RgbdCameraSensor.cc: fix include #280

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 1, 2022

🦟 Bug fix

Follow-up to #277

Summary

Ensure that image.pb.h is included even when _MSC_VER is not defined.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from ahcorde November 1, 2022 23:44
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 1, 2022
@mjcarroll
Copy link
Contributor

🙈

@mjcarroll mjcarroll merged commit 5a82b76 into ign-sensors3 Nov 2, 2022
@mjcarroll mjcarroll deleted the scpeters/fix_rgbd_include branch November 2, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants