Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 ➡️ 5 #154

Merged
merged 11 commits into from
Sep 13, 2021
Merged

4 ➡️ 5 #154

merged 11 commits into from
Sep 13, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-sensors4 to ign-sensors5

Branch comparison: ign-sensors5...ign-sensors4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

iche033 and others added 10 commits July 9, 2021 19:06
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Also fix deprecation warning.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 10, 2021
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #154 (f963332) into ign-sensors5 (ba89178) will increase coverage by 0.41%.
The diff coverage is 88.88%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-sensors5     #154      +/-   ##
================================================
+ Coverage         76.10%   76.52%   +0.41%     
================================================
  Files                23       23              
  Lines              2390     2458      +68     
================================================
+ Hits               1819     1881      +62     
- Misses              571      577       +6     
Impacted Files Coverage Δ
src/Sensor.cc 85.97% <79.48%> (-2.03%) ⬇️
src/CameraSensor.cc 73.89% <83.33%> (+0.53%) ⬆️
src/AirPressureSensor.cc 83.78% <100.00%> (+0.45%) ⬆️
src/AltimeterSensor.cc 86.36% <100.00%> (+0.31%) ⬆️
src/DepthCameraSensor.cc 73.77% <100.00%> (+0.43%) ⬆️
src/GpuLidarSensor.cc 87.26% <100.00%> (+0.16%) ⬆️
src/ImuSensor.cc 89.28% <100.00%> (+0.82%) ⬆️
src/Lidar.cc 70.98% <100.00%> (+0.15%) ⬆️
src/LogicalCameraSensor.cc 87.50% <100.00%> (+0.35%) ⬆️
src/MagnetometerSensor.cc 86.51% <100.00%> (+0.30%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba89178...f963332. Read the comment docs.

@chapulina chapulina mentioned this pull request Sep 10, 2021
7 tasks
@chapulina chapulina mentioned this pull request Sep 10, 2021
7 tasks
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 354b061 into ign-sensors5 Sep 13, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch September 13, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants