Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎈 5.0.0 #294

Merged
merged 1 commit into from
Oct 1, 2021
Merged

🎈 5.0.0 #294

merged 1 commit into from
Oct 1, 2021

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 30, 2021

🎈 Release

Preparation for 5.0.0 release.

Comparison to 4.2.0 : ignition-physics4_4.2.0...ign-physics5

Targets new branch ign-physics5

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Copy link
Contributor Author

azeey commented Sep 30, 2021

The log in /home/jenkins/workspace/ignition_physics-ci-pr_any-ubuntu_auto-amd64/build/test/FAKE_INSTALL-prefix/src/FAKE_INSTALL-stamp/FAKE_INSTALL-build-err.log contains:

c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.
make[5]: *** [dartsim/CMakeFiles/ignition-physics5-dartsim-plugin.dir/src/plugin.cc.o] Error 1
make[4]: *** [dartsim/CMakeFiles/ignition-physics5-dartsim-plugin.dir/all] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [all] Error 2

My guess is the machine ran out of memory as it's easy to happen when compiling ign-physics. Would it be possible to reduce the number of parallel jobs just for ign-physics when running on AWS nodes?

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #294 (8b6f60c) into ign-physics5 (42d2320) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-physics5     #294   +/-   ##
=============================================
  Coverage         75.54%   75.54%           
=============================================
  Files               127      127           
  Lines              5655     5655           
=============================================
  Hits               4272     4272           
  Misses             1383     1383           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d2320...8b6f60c. Read the comment docs.

@chapulina
Copy link
Contributor

Would it be possible to reduce the number of parallel jobs just for ign-physics when running on AWS nodes?

That's a question for @j-rivero

@chapulina
Copy link
Contributor

I think we don't need to block the release on the Jenkins build

@azeey
Copy link
Contributor Author

azeey commented Oct 1, 2021

Okay, can you go ahead and merge it then (it won't let me)? Hopefully it'll pick a better machine for the deb builder.

@chapulina chapulina merged commit ba3eb2c into ign-physics5 Oct 1, 2021
@chapulina chapulina deleted the azeey/prepare_5.0.0 branch October 1, 2021 01:53
@scpeters
Copy link
Member

scpeters commented Oct 1, 2021

Hopefully it'll pick a better machine for the deb builder.

it didn't

@scpeters
Copy link
Member

scpeters commented Oct 1, 2021

Hopefully it'll pick a better machine for the deb builder.

it didn't

I'm manually rerunning these failed builds with the JENKINS_NODE_TAG parameter set to large-memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants