-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ign-physics CI/debbuilds use large-memory label #526
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@@ -617,6 +617,8 @@ def go(argv): | |||
# Need to use JENKINS_NODE_TAG parameter for large memory nodes | |||
# since it runs qemu emulation | |||
linux_platform_params['JENKINS_NODE_TAG'] = 'linux-' + a + '|| large-memory' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as I look more closely at the results of the arm*
debbuilds on native arm machines, I see that many of them failed. It may be safest to require large-memory
for all ign-physics
debbuilds, rather than || large-memory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arm native nodes were not able to compile the physics due to the lack of more memory. Is this the case, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm...
- focal armhf passed on an ARM native node: https://build.osrfoundation.org/job/ign-physics5-debbuilder/380/
- focal arm64 ran on r2d2 with qemu anyway: https://build.osrfoundation.org/job/ign-physics5-debbuilder/381/
but I had big troubles with bionic arm* builds on arm native nodes, though perhaps this is not memory-related:
and then the bionic amd64 build just failed on drogon: |
trying again with |
as an alternative, we could try to limit the number of parallel make jobs in the debian metadata |
We probably need to run builds with current compiling threads on |
I found the problem during building Buster arm on linux-arm nodes. Reducing the threads from 3 to 2 solved the problem for This build https://build.osrfoundation.org/job/ign-physics5-debbuilder/416/ for armhf with 3 compilation threads took 11 min. With this:
|
feel free to make any changes to this PR that you see fit |
Here we go d95ce6c. Tested locally the generation: XML 138 </scriptSource>
139 </hudson.plugins.groovy.SystemGroovy>
140 <hudson.tasks.Shell>
141 <command> #!/bin/bash -xe
142
143 export INVALIDATE_DOCKER_CACHE=true
144 if [[ $(uname -m) == "aarch64" ]]; then export MAKE_JOBS=2; fi
145
146 /bin/bash -x ./scripts/jenkins-scripts/docker/multidistribution-ignition-debbuild.bash
147 </command> Injected manually in debbuilder: [ign-physics5-debbuilder] $ /bin/bash -xe /tmp/jenkins6849195079577325454.sh
+ export INVALIDATE_DOCKER_CACHE=true
+ INVALIDATE_DOCKER_CACHE=true
++ uname -m
+ [[ aarch64 == \a\a\r\c\h\6\4 ]]
+ export MAKE_JOBS=2
+ MAKE_JOBS=2
+ /bin/bash -x ./scripts/jenkins-scripts/docker/multidistribution-ignition-debbuild.bash
...
# BEGIN SECTION: create deb packages
+ debuild --no-tgz-check -uc -us --source-option=--include-binaries -j2
dpkg-buildpackage -us -uc -ui --source-option=--include-binaries -j2
dpkg-buildpackage: info: source package ignition-physics5
dpkg-buildpackage: info: source version 5.0.0-3~buster
dpkg-buildpackage: info: source distribution buster
... |
I ran a build of ign-physics4 locally with It might be better to just set the number of parallel jobs to 2 or even 1. |
CI failed in gazebosim/gz-physics#294 on a non-
large-memory
machine, and several debbuilds failed as well. Let's requirelarge-memory
for all ign-physics CI and debbuild jobs.