Print error when unzipping fails to save a file

[chapulina]

🦟 Bug fix

Summary

While reviewing gazebosim/gz-sim#1262, some files were failing to download, but I was getting success messages. This PR just makes sure that a success message isn't printed on failure.

Before this PR we get false positives:

$ ign fuel download -v 4 --url "https://fuel.ignitionrobotics.org/1.0/jennuine/models/Monterey Bay"          
Downloading model:                                                                                                                          
  Name: monterey bay                                                                                                                          Owner: jennuine                                                                                                                           
  Server:                                                                                                                                   
    URL: https://fuel.ignitionrobotics.org                                                                                                  
    Version: 1.0                                                                                                                            
                                                                                                                                            
[Msg] Downloading model [https://fuel.ignitionrobotics.org/jennuine/models/monterey bay]                                                    
[Dbg] [Zip.cc:176] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/dem/]              
[Dbg] [Zip.cc:176] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/dem/monterey_bay_gebco_2021.tif]                                                                                                                               
[Dbg] [Zip.cc:176] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/materials/]        
[Dbg] [Zip.cc:176] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/materials/textures/]                                                                                                                                           
[Dbg] [Zip.cc:176] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/materials/textures/monterey_bay_gebco_2021_colormap.png] 
[Dbg] [Zip.cc:176] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/materials/textures/monterey_bay_gebco_2021_relief.png] 
[Dbg] [Zip.cc:176] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/model.config]                                                                                                       
[Dbg] [Zip.cc:176] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/model.sdf]                                                                                                      
[Dbg] [Zip.cc:176] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/thumbnails/]       
[Dbg] [Zip.cc:176] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/thumbnails/1.png] 

After:

$ ign fuel download -v 4 --url "https://fuel.ignitionrobotics.org/1.0/jennuine/models/Monterey Bay"
Downloading model: 
  Name: monterey bay
  Owner: jennuine
  Server:
    URL: https://fuel.ignitionrobotics.org
    Version: 1.0

[Msg] Downloading model [https://fuel.ignitionrobotics.org/jennuine/models/monterey bay]
[Err] [Zip.cc:175] Failed to write file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/dem/]
[Err] [Zip.cc:175] Failed to write file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/dem/monterey_bay_gebco_2021.tif]
[Err] [Zip.cc:175] Failed to write file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/materials/]
[Err] [Zip.cc:175] Failed to write file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/materials/textures/]
[Err] [Zip.cc:175] Failed to write file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/materials/textures/monterey_bay_gebco_2021_colormap.png]
[Err] [Zip.cc:175] Failed to write file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/materials/textures/monterey_bay_gebco_2021_relief.png]
[Dbg] [Zip.cc:179] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/model.config]
[Dbg] [Zip.cc:179] Created file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/model.sdf]
[Err] [Zip.cc:175] Failed to write file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/thumbnails/]
[Err] [Zip.cc:175] Failed to write file [/home/developer/.ignition/fuel/fuel.ignitionrobotics.org/jennuine/models/monterey bay/2/thumbnails/1.png]
Download succeeded.

PS: The issue downloading these files on Garden should be fixed by gazebosim/gz-common#308

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

[codecov]

Codecov Report

Merging #235 (a42fd16) into ign-fuel-tools4 (ae90993) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@                 Coverage Diff                 @@
##           ign-fuel-tools4     #235      +/-   ##
===================================================
+ Coverage            77.90%   77.92%   +0.02%     
===================================================
  Files                   19       19              
  Lines                 2715     2718       +3     
===================================================
+ Hits                  2115     2118       +3     
  Misses                 600      600              

Impacted Files	Coverage Δ
src/Zip.cc	69.87% <75.00%> (+1.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae90993...a42fd16. Read the comment docs.