Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add allowChaiExclude option #15

Merged
merged 1 commit into from
Feb 9, 2021
Merged

feat: add allowChaiExclude option #15

merged 1 commit into from
Feb 9, 2021

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Feb 9, 2021

feat: add allowChaiExclude option to support https://github.com/mesaugat/chai-exclude

@brettz9 brettz9 mentioned this pull request Feb 9, 2021
Merged
gavinaiken
gavinaiken reviewed Feb 9, 2021
View reviewed changes
Copy link
Owner

@gavinaiken gavinaiken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. 👍

@gavinaiken gavinaiken merged commit 31e315e into gavinaiken:master Feb 9, 2021
@gavinaiken
Copy link
Owner

Merged this and the deps bump, updated the README and published as version 2.1.0

@brettz9
Copy link
Contributor Author

brettz9 commented Feb 9, 2021

Great, thanks a lot! And, sorry I forgot to update the README. I didn't see any commit from you updating it. Would you like one?

@brettz9 brettz9 deleted the chai-exclude branch February 9, 2021 14:05
@gavinaiken
Copy link
Owner

I forgot to push to github! Just done so. 8b21ae3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinaiken gavinaiken gavinaiken left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettz9 @gavinaiken