Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): fix types for printTypeDefinitions action #37647

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix(gatsby): fix types for printTypeDefinitions action #37647

merged 1 commit into from
Feb 13, 2023

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Feb 13, 2023

Description

Our types for printTypeDefinitions actions in index.d.ts is wrong and doesn't match actual signature (

gatsby/packages/gatsby/src/redux/actions/restricted.ts

Lines 350 to 364 in 7dfef03

printTypeDefinitions: (
{
path = `schema.gql`,
include,
exclude,
withFieldTypes = true,
}: {
path?: string
include?: { types?: Array<string>; plugins?: Array<string> }
exclude?: { types?: Array<string>; plugins?: Array<string> }
withFieldTypes?: boolean
},
plugin: IGatsbyPlugin,
traceId?: string
): IPrintTypeDefinitions => {
)

Documentation

Related Issues

Fixes #37642

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 13, 2023
@pieh pieh added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 13, 2023
@pieh pieh mentioned this pull request Feb 13, 2023
Closed
2 tasks
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 13, 2023

✅ gatsby-master deploy preview ready

@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Feb 13, 2023 •
edited
Loading

✅ benchmarks-mdx deploy preview ready

@gatsby-cloud-staging
Copy link

❌ gatsby-master deploy preview failed

Your build failed. View the build logs.

1 similar comment
@gatsby-cloud-staging
Copy link

❌ gatsby-master deploy preview failed

Your build failed. View the build logs.

@LekoArts LekoArts merged commit bc6c3ef into master Feb 13, 2023
@LekoArts LekoArts deleted the fix/ts-print-schema-customization branch February 13, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

printTypeDefinitions expects string argument in TS type definition
2 participants
@pieh @LekoArts