feat: GraphiQL v2 #36541
Merged
feat: GraphiQL v2 #36541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
topic: DX
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
LekoArts
commented
Sep 6, 2022
pieh
reviewed
Oct 18, 2022
| const fragmentsUrlHandler = path.posix.join(graphqlEndpoint, `fragments`) | ||
|
|
||
| expressApp.get(bundleUrlHandler, (_req, res) => { | ||
| res.set(`Cache-Control`, `public, max-age=31557600`) |
There was a problem hiding this comment.
this Cache-Control (which I know is copied from current stuff), in general seems problematic because it does force "force refresh" or disabling browser cache. So not for this PR, but probably something for next time we mess with with graphiql app (or maybe add etag somehow to be able to invalidate browser cache)
pieh
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New GraphiQL version is out with some nice, new features!
TODOs:
@graphiql/plugin-code-exportergraphql/graphiql#2758 so in our package for now)Documentation
We need to update some internal docs like:
Separate PR: #36837
External: https://github.com/graphql/graphiql/blob/main/docs/migration/graphiql-2.0.0.md
Related Issues
[ch55244]