-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GraphiQL v2 #36541
feat: GraphiQL v2 #36541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one change needed and we can merge
const fragmentsUrlHandler = path.posix.join(graphqlEndpoint, `fragments`) | ||
|
||
expressApp.get(bundleUrlHandler, (_req, res) => { | ||
res.set(`Cache-Control`, `public, max-age=31557600`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this Cache-Control
(which I know is copied from current stuff), in general seems problematic because it does force "force refresh" or disabling browser cache. So not for this PR, but probably something for next time we mess with with graphiql app (or maybe add etag
somehow to be able to invalidate browser cache)
Description
New GraphiQL version is out with some nice, new features!
TODOs:
@graphiql/plugin-code-exporter
graphql/graphiql#2758 so in our package for now)Documentation
We need to update some internal docs like:
Separate PR: #36837
External: https://github.com/graphql/graphiql/blob/main/docs/migration/graphiql-2.0.0.md
Related Issues
[ch55244]