Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Set staticQueryResultHash to new hash #32949

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

herecydev
Copy link
Contributor

Description

Sets the tracked hash to the new hash if the query was dirty

Related Issues

Fixes #25928

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 28, 2021
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this change make total sense. Thank you for the fix!

@pieh pieh merged commit 88e1559 into gatsbyjs:master Aug 30, 2021
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 30, 2021
@KyleAMathews
Copy link
Contributor

Ooo nice find! This definitely solves some of the "static query cannot be found" issues.

@herecydev herecydev deleted the topic/staticQueryHash branch August 30, 2021 15:08
vladar pushed a commit that referenced this pull request Aug 31, 2021
…2949)

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit 88e1559)
vladar pushed a commit that referenced this pull request Aug 31, 2021
…2949) (#32966)

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit 88e1559)

Co-authored-by: Dan Kirkham <herecy@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional page builds not working with static queries
3 participants