Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-image): Apply inline styles and img size #29603

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Feb 19, 2021

Apply inline styles to the wrapper element if the plugin isn't installed. Add width and height props to the img tag. They're not needed as we use CSS, but Lighthouse warns about them anyway

[ch24990]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 19, 2021
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can accept this :)
And ya, the width/height stuff is good to remove the warning.

@ascorbic ascorbic added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 19, 2021
@gatsbybot gatsbybot merged commit 9db36db into master Feb 19, 2021
@gatsbybot gatsbybot deleted the fix/image-wrapper-style branch February 19, 2021 13:35
ascorbic added a commit that referenced this pull request Feb 22, 2021
ascorbic added a commit that referenced this pull request Feb 22, 2021
ascorbic added a commit that referenced this pull request Feb 22, 2021
ascorbic added a commit that referenced this pull request Feb 23, 2021
…29668)

(cherry picked from commit 9db36db)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@ascorbic
Copy link
Contributor Author

Published in gatsby-plugin-image@0.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants