Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-admin): stop eslint from erroring on built bundles in development #25635

Merged
merged 2 commits into from
Jul 13, 2020
Merged

chore(gatsby-admin): stop eslint from erroring on built bundles in development #25635

merged 2 commits into from
Jul 13, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Jul 9, 2020

No description provided.

@mxstbr mxstbr requested a review from a team as a code owner July 9, 2020 08:18
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 9, 2020
@mxstbr mxstbr added topic: admin and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 9, 2020
@gatsby-cloud-staging
Copy link

Your pull request can be previewed in Gatsby Cloud: https://build-b064ddbe-77cc-48aa-95e2-58d7a9836162.staging-previews.gtsb.io

@mxstbr mxstbr mentioned this pull request Jul 9, 2020
Closed
johno
johno previously approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@LekoArts
Copy link
Contributor

LekoArts commented Jul 13, 2020 •
edited
Loading

Was this solved by #25714 ?

@mxstbr
Copy link
Contributor Author

mxstbr commented Jul 13, 2020

No this is to fix ESLint errors appearing when you run gatsby develop in the gatsby-admin package! Good question 👍

@mxstbr mxstbr merged commit da4b3ec into master Jul 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the admin/fix-eslint-ignore branch July 13, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johno johno johno left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxstbr @LekoArts @johno