Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-recipes): Add GatsbyPage provider #25248

Merged
merged 9 commits into from
Jul 9, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Jun 24, 2020

This adds a GatsbyPage provider to the recipes GraphQL server, which allows us to fetch a list of pages in a Gatsby site. Note that this only implements reading, I'm leaving the create/update/delete functionality a noop for now.

Screenshot 2020-06-25 at 12 33 47

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 24, 2020
@mxstbr mxstbr added topic: recipes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 24, 2020
@mxstbr mxstbr changed the title WIP: Add GatsbyPage provider to recipes feat(gatsby-recipes): Add GatsbyPage provider Jun 25, 2020
@mxstbr mxstbr marked this pull request as ready for review June 25, 2020 10:34
@mxstbr mxstbr requested review from a team as code owners June 25, 2020 10:34
johno
johno previously approved these changes Jun 30, 2020
Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ The page resource provider looks great! Just had one tiny nit.

We should probably have someone from @gatsbyjs/core review the unlock code since I'm not very familiar with what's going on there, and not sure if there might be unintended side effects.

packages/gatsby-recipes/src/providers/gatsby/page.js Outdated Show resolved Hide resolved
@mxstbr
Copy link
Contributor Author

mxstbr commented Jun 30, 2020

We should probably have someone from @gatsbyjs/core review the unlock code since I'm not very familiar with what's going on there, and not sure if there might be unintended side effects.

@sidharthachatterjee and @pieh helped me figure that out 😬

@gatsby-cloud-staging
Copy link

Your pull request can be previewed in Gatsby Cloud: https://build-5c4c1c47-86b4-4567-96d9-55208c478277.staging-previews.gtsb.io

@mxstbr mxstbr merged commit 9c58ee1 into master Jul 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the recipes-gatsby-page-provider branch July 9, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants