Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Migrate utils/get-cache.js to ts #22094

Merged
merged 2 commits into from
Mar 9, 2020
Merged

chore(gatsby): Migrate utils/get-cache.js to ts #22094

merged 2 commits into from
Mar 9, 2020

Conversation

cola119
Copy link
Contributor

@cola119 cola119 commented Mar 9, 2020

Description

Convert utils/get-cache to typescript

Documentation

Related Issues

Related to #21995

@cola119 cola119 requested a review from a team as a code owner March 9, 2020 14:21
@blainekasten blainekasten mentioned this pull request Mar 9, 2020
Closed
blainekasten
blainekasten previously approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@blainekasten blainekasten added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 9, 2020
@cola119
Copy link
Contributor Author

cola119 commented Mar 9, 2020

@blainekasten
I'm so sorry I forgot to change a require statement. I fixed this in 2f9b8ed (and lint changed let to const automatically)

blainekasten
blainekasten approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@gatsbybot gatsbybot merged commit f607506 into master Mar 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/ts/get_cache branch March 9, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cola119 @blainekasten @gatsbybot