Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update import statements to esm #21700

Merged
merged 4 commits into from
Mar 30, 2020
Merged

chore: update import statements to esm #21700

merged 4 commits into from
Mar 30, 2020

Conversation

sergeycw
Copy link
Contributor

Description

All import statements in documentation and internal code changed from import React from 'react' to import * as React from 'react'

Documentation

Related Issues

Fixes #21697

@sergeycw sergeycw requested review from a team as code owners February 24, 2020 13:05
@wardpeet wardpeet self-assigned this Feb 29, 2020
@KyleAMathews
Copy link
Contributor

@sergeycw looks like there's some test failures — could you look into this?

@wardpeet wardpeet changed the title import statement updated chore: update import statements to esm Mar 30, 2020
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergeycw this looks great!

I've tested this on the earliest react version and 👍

@wardpeet wardpeet merged commit dd18fc2 into gatsbyjs:master Mar 30, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 30, 2020

Holy buckets, @sergeycw — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to import * as React from 'react' and remove commonjs interop import
3 participants