Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): update key name for jest@24 support #11302

Merged
merged 1 commit into from
Jan 28, 2019
Merged

fix(docs): update key name for jest@24 support #11302

merged 1 commit into from
Jan 28, 2019

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 25, 2019

Description

Jest recently added a "Deprecation Warning" saying

Option "setupTestFrameworkScriptFile" was replaced by configuration "setupFilesAfterEnv", which supports multiple paths.

This PR fixes the docs to match the newly updated configuration.

screen shot 2019-01-25 at 3 34 06 pm

@jsjoeio jsjoeio requested a review from a team January 25, 2019 22:45
@LekoArts
Copy link
Contributor

Hi, thanks for the PR. However, as I understand it it's still in beta release? jestjs/jest#7119 (comment)
So reading that I don't think we should merge that just yet.

@DSchau
Copy link
Contributor

DSchau commented Jan 28, 2019

@LekoArts it's available in Jest@24--which released last week!

I've updated the documentation and examples, and the PR was just merged in #11293!

This is actually in a separate file that I missed--so let's get this merged.

Thanks Joe!

DSchau
DSchau approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DSchau DSchau changed the title Testing React Components - Update key name in jest.config.js fix(docs): update key name for jest@24 support Jan 28, 2019
@DSchau DSchau merged commit 2ddb20c into master Jan 28, 2019
@DSchau DSchau deleted the jsjoeio-patch-1 branch January 28, 2019 14:44
wardpeet pushed a commit that referenced this pull request Feb 11, 2019
@jsjoeio @wardpeet
fix(docs): update key name for jest@24 support (#11302)
b8c62de 
## Description

Jest recently added a "Deprecation Warning" saying 
> Option "setupTestFrameworkScriptFile" was replaced by configuration "setupFilesAfterEnv", which supports multiple paths.

This PR fixes the docs to match the newly updated configuration.

![screen shot 2019-01-25 at 3 34 06 pm](https://user-images.githubusercontent.com/3806031/51776858-29457580-20b8-11e9-80b1-76b955e01191.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsjoeio @LekoArts @DSchau