Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch GCR -> Artifact-Registry #878

Merged
merged 3 commits into from
Dec 6, 2023
Merged

switch GCR -> Artifact-Registry #878

merged 3 commits into from
Dec 6, 2023

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Dec 5, 2023 •
edited by himanshu-kun
Loading

GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

  • europe-docker.pkg.dev/gardener-project/snapshots for snapshots
  • europe-docker.pkg.dev/gardener-project/releases for releases
  • europe-docker.pkg.dev/gardener-project/public for combined view of snapshots + releases

In addition, switch testmachinery-Image to new location in Artifact-Registry.

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

@ccwienk
cleanup: rm obsolete/redundant attributes
bebc1ba
@ccwienk
switch to new testmachinery-image-location
a1bf6a7
@ccwienk
switch GCR -> Artifact-Registry
0c968fb 
GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

- europe-docker.pkg.dev/gardener-project/snapshots for snapshots
- europe-docker.pkg.dev/gardener-project/releases for releases
- europe-docker.pkg.dev/gardener-project/public for read-access to
  snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
@ccwienk ccwienk requested a review from a team as a code owner December 5, 2023 19:57
@gardener-robot gardener-robot added the needs/review Needs review label Dec 5, 2023
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Dec 5, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 5, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 5, 2023
himanshu-kun
himanshu-kun approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks for the changes. should we raise similar PRs on mcm-providers or would you be taking care of the same?

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 6, 2023
@himanshu-kun himanshu-kun self-assigned this Dec 6, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2023
hendrikKahl
hendrikKahl approved these changes Dec 6, 2023
View reviewed changes
Copy link

@hendrikKahl hendrikKahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
(for the testmachinery part)

@himanshu-kun himanshu-kun merged commit d5d385b into master Dec 6, 2023
8 checks passed
@himanshu-kun himanshu-kun deleted the gcr-to-ar branch December 6, 2023 07:47
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikKahl hendrikKahl hendrikKahl approved these changes

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees

@himanshu-kun himanshu-kun

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ccwienk @hendrikKahl @himanshu-kun @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot