Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include UnavailableReplicas in MCD status update check #833

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Include UnavailableReplicas in MCD status update check #833

merged 1 commit into from
Jun 21, 2023

Conversation

rishabh-11
Copy link
Contributor

What this PR does / why we need it:
Includes UnavailableReplicas in determining if the status of machine deployment needs to be updated.

Which issue(s) this PR fixes:
Fixes #832

Special notes for your reviewer:

Release note:

Included `UnavailableReplicas` in determining if a machine deployment status update is needed

@rishabh-11 rishabh-11 requested a review from a team as a code owner June 21, 2023 08:24
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 21, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 21, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 21, 2023
elankath
elankath approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@elankath elankath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigation and fix.

@rishabh-11 rishabh-11 merged commit 8234b00 into gardener:master Jun 21, 2023
1 check passed
@rishabh-11 rishabh-11 deleted the mcd-update-check branch June 21, 2023 08:53
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 21, 2023
@ialidzhikov ialidzhikov mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elankath elankath elankath approved these changes

Assignees

@elankath elankath

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnavailableReplicas not checked for machine deployment status update
5 participants
@rishabh-11 @elankath @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot