Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

History #512

Merged
merged 1 commit into from
Jul 6, 2021
Merged

History #512

merged 1 commit into from
Jul 6, 2021

Conversation

tedteng
Copy link
Contributor

@tedteng tedteng commented Apr 28, 2021

What this PR does / why we need it:
add History Targetting the idea comes from #499 (comment) in History Targetting section
Which issue(s) this PR fixes:
Fixes #511

Special notes for your reviewer:

Release note:

Targeting history feature eg `gardenctl x`

@tedteng tedteng requested a review from a team as a code owner April 28, 2021 04:50
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Apr 28, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 28, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Apr 28, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 28, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@tedteng
Copy link
Contributor Author

tedteng commented Apr 28, 2021

feel free to have a look at the target history feature. I will create a new ticket for history_test.go under folder internal\history later.

cc: @vlerenc and @petersutter

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 29, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 27, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 28, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 28, 2021
@petersutter
Copy link
Contributor

petersutter commented Jun 28, 2021

or you want to display kubeconfig path as well after gardenctl x

this - I see you already did it

@petersutter
Copy link
Contributor

the PR looks good for me, except maybe for one thing:

I would expect that when choosing a target from the history list, that the chosen target would appear at the top of the list. Not sure what the others think about that.

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 29, 2021
@tedteng
Copy link
Contributor Author

tedteng commented Jun 29, 2021

the PR looks good for me, except maybe for one thing:

I would expect that when choosing a target from the history list, that the chosen target would appear at the top of the list. Not sure what the others think about that.

sounds reasonable, done in 82f980a

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 1, 2021
@petersutter petersutter self-requested a review July 1, 2021 07:25
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Jul 1, 2021
@tedteng
Copy link
Contributor Author

tedteng commented Jul 5, 2021

/merge squash

@gardener-robot gardener-robot added the merge/squash Should be merged via 'Squash and merge' label Jul 5, 2021
@tedteng
Copy link
Contributor Author

tedteng commented Jul 5, 2021

/help

@gardener-robot
Copy link

@tedteng Here my list of commands:

Man Page
Synopsis What & Who Description & Examples
/assign [@user...] Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Commenter
Assign given people (or yourself if none specified) to issue or PR. Commenters may only assign themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /assign
- /assign @johndoe @janedoe
- /assign platform/bare-metal
/unassign [@user...] Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Commenter
Unassign given people (or yourself if none specified) from issue or PR. Commenters may only unassign themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /unassign
- /unassign @johndoe @janedoe
- /unassign platform/bare-metal
/cla Valid for
PullRequest
Permitted for
Anyone
Recheck Contributor License Agreement (CLA) for PR.
Examples:
- /cla
/diag Valid for
Issue
Permitted for
Member,
Author,
Commenter
Run diagnosis on shoot cluster. Can only be invoked with a shoot cluster dashboard link as argument or for shoot cluster issues with a dashboard link in the body and labeled with topology/shoot. Can only be invoked by Gardener staff, shoot cluster project members, or issue authors.
Examples:
- /diag
/duplicate Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Mark issue or PR as duplicate of another one. The referenced issue/PR may be in the same repo (e.g. #123 or GH-123), on the same server (e.g. org/repo#123), or even on another server (e.g. https://server/org/repo/issues/123). Author, assignees, and code owners of the referenced issue/PR will be informed about this duplicate. Information will be redacted if this duplicate is private and the referenced one is public. An attempt to reference a private issue/PR from public will be rejected.
Examples:
- /duplicate
/help Valid for
Issue,
PullRequest
Permitted for
Anyone
Get help on all available commands.
Examples:
- /help
Synonyms: /help, /hi, /hello, /hola, /hallo, /rtfm
/add label... Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Add label to issue or PR (default if no command is recognized). Authors may only add certain white-listed labels such as kind/*, priority/*, area/*, component/*, os/*, platform/*. The labels can be either fully qualified like kind/bug, just the identifier like bug, or starting with the category like kind followed by one or many identifiers in that category.
Examples:
- /add area/cost component/gardener
- /add cost gardener
- /add kind bug regression
- /area/cost component/gardener
- /cost gardener
- /kind bug regression
Synonyms: /add, /set, /label, /start, /begin
/remove label... Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Remove label from issue or PR. Authors may only remove certain white-listed labels such as kind/*, priority/*, area/*, component/*, os/*, platform/*. The labels can be either fully qualified like kind/bug, just the identifier like bug, or starting with the category like kind followed by one or many identifiers in that category.
Examples:
- /remove area/cost component/gardener
- /remove cost gardener
- /remove kind bug regression
Synonyms: /remove, /rem, /unset, /unlabel, /stop, /end, /del, /drop, /cancel
/lgtm Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member
Add reviewed/lgtm label to issue or PR (and remove conflicting labels).
Examples:
- /lgtm
/hold Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Add reviewed/do-not-merge label to issue or PR (and remove conflicting labels).
Examples:
- /hold
/unhold Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Remove reviewed/do-not-merge label from issue or PR.
Examples:
- /unhold
/close Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Close issue or PR.
Examples:
- /close
/reopen Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Reopen issue or PR.
Examples:
- /reopen
Synonyms: /reopen, /open
/touch Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Remove lifecycle/icebox, stale, or rotten label from issue or PR. Authors may only remove the stale or rotten labels.
Examples:
- /touch
/plan milestone Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member
Set milestone for issue/PR.
Examples:
- /plan 2030-Q1
Synonyms: /plan, /schedule, /milestone
/unplan Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member
Unset milestone for issue.
Examples:
- /unplan
Synonyms: /unplan, /unschedule, /unmilestone
/ping [@user...] [msg] Valid for
Issue,
PullRequest
Permitted for
Anyone
Ping people (or just in general if none specified) with a message to take a look at issue or PR (like /honk in prow). Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /ping
- /ping @johndoe @janedoe Have you checked?
- /ping platform/bare-metal Any Progress?
Synonyms: /ping, /honk
/ready-for-review Valid for
PullRequest
Permitted for
Maintainer,
Member,
Author
Turn draft PR into ready for review PR.
Examples:
- /ready-for-review
Synonyms: /ready-for-review, /ready
/invite [@user...] Valid for
PullRequest
Permitted for
Maintainer,
Member,
Author,
Commenter
Request PR review from given people (or yourself if none specified) for PR. Commenters may only invite themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /invite
- /invite @johndoe @janedoe
- /invite platform/bare-metal
Synonyms: /invite, /review
/uninvite [@user...] Valid for
PullRequest
Permitted for
Maintainer,
Member,
Commenter
No longer request PR review from given people (or yourself if none specified) for PR. Commenters may only uninvite themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /uninvite
- /uninvite @johndoe @janedoe
- /uninvite platform/bare-metal
Synonyms: /uninvite, /unreview
/title title Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Change title of issue or PR.
Examples:
- /title Add metrics endpoint
Synonyms: /title, /retitle

@tedteng tedteng removed the merge/squash Should be merged via 'Squash and merge' label Jul 5, 2021
add history write
add target name into local history file
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Jul 5, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 6, 2021
@tedteng tedteng merged commit f75ad16 into gardener-attic:master Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

target history feature
7 participants