Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

add passing custom arguments - aws/gcp/az #423

Merged
merged 1 commit into from
Nov 10, 2020
Merged

add passing custom arguments - aws/gcp/az #423

merged 1 commit into from
Nov 10, 2020

Conversation

tedteng
Copy link
Contributor

@tedteng tedteng commented Nov 2, 2020 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #418
Fixes #419
Fixes #420
Special notes for your reviewer:

Release note:

add passing arguments in ssh  eg `gardenctl ssh node ls /tmp`

@tedteng tedteng requested a review from a team as a code owner November 2, 2020 06:34
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 2, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 2, 2020
@tedteng tedteng force-pushed the ssh_aws_cleanup branch 2 times, most recently from 8f3cf1e to 96ef0e1 Compare November 2, 2020 06:36
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 2, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 2, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 2, 2020
@tedteng tedteng changed the title add passing custom arguments - aws add passing custom arguments - aws/gcp/az Nov 6, 2020
dansible
dansible approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@dansible dansible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @tedteng 👍

@gardener-robot gardener-robot removed the needs/review Needs review label Nov 9, 2020
@neo-liang-sap neo-liang-sap merged commit 1ebe0b8 into gardener-attic:master Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dansible dansible dansible approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
6 participants
@tedteng @dansible @gardener-robot-ci-1 @neo-liang-sap @gardener-robot-ci-3 @gardener-robot