Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Do not use deprecated project name label #412

Merged

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Oct 27, 2020

What this PR does / why we need it:
project.garden.sapcloud.io/name is deprecated with gardener/gardener#1833 and will be removed in a future release of gardener/gardener.

Release note:

gardenctl no longer relies on the deprecated `project.garden.sapcloud.io/name` label

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested a review from a team as a code owner October 27, 2020 14:23
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 27, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 27, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 27, 2020
@gardener-robot gardener-robot removed the needs/review Needs review label Oct 27, 2020
@neo-liang-sap neo-liang-sap merged commit f14cfa4 into gardener-attic:master Oct 28, 2020
@ialidzhikov
Copy link
Contributor Author

@gardener/gardenctl-maintainers , can we cut a new release of gardenctl (new patch release or new minor release, I don't know whether you already have some plans for a release) that includes this PR?
Background - there is gardener/gardener#3094 that wants to remove this project.garden.sapcloud.io/name label (which would cause gardenctl target command to fail).

@neo-liang-sap
Copy link
Contributor

@dansible , your thoughts? on the release plan

@ialidzhikov ialidzhikov deleted the cleanup/project-label branch November 10, 2020 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants