enable ssh debug and Error msg debug #264
Conversation
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
|
@tedteng in description |
|
@neo-liang-sap seems you are just close the issue #259. |
|
/lgtm |
pkg/cmd/root.go
Outdated
| @@ -129,6 +130,7 @@ func init() { | |||
|
|
|||
| RootCmd.PersistentFlags().BoolVarP(&cachevar, "no-cache", "c", false, "no caching") | |||
| RootCmd.PersistentFlags().StringVarP(&outputFormat, "output", "o", "yaml", "output format yaml or json") | |||
| RootCmd.PersistentFlags().BoolVarP(&debugSwitch, "debug", "d", false, "enable debug level output") | |||
There was a problem hiding this comment.
| RootCmd.PersistentFlags().BoolVarP(&debugSwitch, "debug", "d", false, "enable debug level output") | |
| RootCmd.PersistentFlags().BoolVarP(&debugSwitch, "debug", "d", false, "enable debug level output") |
Could we name it "verbose" as it is not necessarily for debugging?
Just a personal preference though.
There was a problem hiding this comment.
Mhm I see that there is already a previous commit that introduces the debug flag.
Maybe @DockToFuture has an opinion about the naming of the flag aswell?
There was a problem hiding this comment.
sure, np, that part I just copy from the previous commit for my testing purpose at that time, before that commit merger. Now it changes back.
There was a problem hiding this comment.
So you want to have the flag named --debug and not --verbose ?
There was a problem hiding this comment.
I mean after rebase it change back. I am fine with verbose I can change --debug to --verbose
There was a problem hiding this comment.
done. @danielfoehrKn let me know if there anything else need update.
pkg/cmd/ssh_aws.go
Outdated
| @@ -51,6 +51,8 @@ type AwsInstanceAttribute struct { | |||
| MyPublicIP string | |||
| } | |||
|
|
|||
| var sshCmd string | |||
|
This PR seems to include also changes from this previous commit - could you rebase? |
gardener-robot-ci-2
added
reviewed/ok-to-test
done |
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
@danielfoehrKn do you still have comments regarding this PR? |
|
@danielfoehrKn ping, do you still have comments on this PR? |
What this PR does / why we need it:
enable ssh debug msg
enhance error msg debug msg, make more meaning
Which issue(s) this PR fixes:
Fixes #265
Special notes for your reviewer:
Release note: