This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Limit SSH node security group to Bastion IP #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfortin-sap Thank you for your contribution. |
|
Thank you @jfortin-sap for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
|
nice, how about also include the AZ and GCP |
|
@tedteng AZ/GCP is already fine |
|
/lgtm |
|
/lgtm , @jfortin-sap could you please rebase these two commits into one? thanks! |
jfortin-sap-zz
force-pushed
the
lock-node-ssh-sec-group
branch
from
d1b10aa
to
3a65cda
Compare
|
@neo-liang-sap done |
neo-liang-sap
approved these changes
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Limit SSH node security group to Bastion IP
Which issue(s) this PR fixes:
Fixes #248
Special notes for your reviewer:
Release note: