SSH code optimization #231
Conversation
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
| @@ -72,13 +72,27 @@ func sshToAWSNode(nodeName, path, user, pathSSKeypair string, sshPublicKey []byt | |||
| fmt.Println("(3/4) Creating bastion host") | |||
| a.createBastionHostInstance() | |||
|
|
|||
| fmt.Println("Waiting SSH 22 port open") | |||
There was a problem hiding this comment.
Maybe in the future it makes sense to have a logging framework with configurable verbosity levels.
For instance to also see verbose output of the SSH command (good for understanding what went wrong).
Just to keep in mind.
There was a problem hiding this comment.
sure np, at the moments, after fixing the ssh process display looks like this when ssh failure" we can get brief information closed by 3.121.114.80 port 22 to identify the issue from local to bastion instance or bastion instance to node instance.
SSH gardener@3.121.114.80 => gardener@ip-10-250-23-169.eu-central-1.compute.internalConnection closed by 3.121.114.80 port 22
kex_exchange_identification: Connection closed by remote host
exit status 255
After investigation this time, I got some new findings. I think the root cause is from AWS EC2, As testing, SSH service of EC2 instance may not fully running immediately when EC2 instance status become running from pending/Initializing.. which causes SSH command may be hung at the first time until timeout exit. so I detecting 22 port open and retry ssh command this time.
-Ted
|
Thanks @neo-liang-sap ! |
What this PR does / why we need it:
increase stability of the existing ssh and code optimization to fix the ssh unstable connection issue.
add bastion ssh port open detect before ssh exected.
even ssh open already sometimes AWS bastion still not ready to connect. so add ssh retry 3 time to fix the case
add prompt msg as verbosity when ssh, the error msg from ssh will return issues from bastion or attend to connect nodes
Which issue(s) this PR fixes:
Fixes #229
Special notes for your reviewer:
@danielfoehrKn
Release note:
increase the stability of the existing ssh and code optimization.