check instance-status.status,Values=ok before SSH #203
Conversation
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
README.md
Outdated
| @@ -154,7 +154,7 @@ Targets represent a hierarchical structure of resources. On top, there is/are th | |||
| `gardenctl ls issues` | |||
| - Drop an element from target stack | |||
| `gardenctl drop` | |||
| - Open a shell to a cluster node | |||
There was a problem hiding this comment.
Would leave it shell as we don't use ssh forwarding over a pod.
There was a problem hiding this comment.
I see, I will rollback this change.
pkg/cmd/ssh_aws.go
Outdated
| @@ -284,6 +282,23 @@ func (a *AwsInstanceAttribute) createBastionHostInstance() { | |||
| capturedOutput, err := captured() | |||
| checkError(err) | |||
| a.BastionIP = capturedOutput | |||
| // check instance-status.status,Values=ok before SSh" | |||
There was a problem hiding this comment.
I tested it with the instance-status.status check and it takes a long time until the instance status check is successful. Not sure if we should really add this check because we can ssh onto the instance even before the check is ready. The operators will probably get annoyed by waiting 4-5 minutes to ssh to the instance. WDYT?
There was a problem hiding this comment.
em, I will double-check it again.
because last time I failed to use ssh onto the instance even before the check is ready
There was a problem hiding this comment.
Please double check, I tested it and for me it worked before the status check was succesful, but it is good if you can confirm it as well.
There was a problem hiding this comment.
yes you are right, It may be network issue when I testing before in APJ region.
There was a problem hiding this comment.
close it, and Please have review the PR only for bastioninstan name check #207
gardener-robot-ci-2
added
the
reviewed/ok-to-test
What this PR does / why we need it:
check instance-status.status,Values=ok before SSH AWS instance
Which issue(s) this PR fixes:
Fixes #191
Special notes for your reviewer:
Release note: