Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required fields to getExercises query #2433

Merged

Conversation

flacial
Copy link
Member

@flacial flacial commented Oct 18, 2022

Related to #1990

Description

  1. Remove discordUsername from the query because in the exercises resolver, the returned user object doesn't have a discordUsername and the query end up throwing an error:
Cannot return null for non-nullable field Author.discordUsername
  1. Adds discordId so the admin can copy the exercise author discord id and quickly message them
  2. Add flaggedAt and flagReason as they'll be used in the Exercise card component and this line

@vercel
Copy link

vercel bot commented Oct 18, 2022

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #2433 (efbafca) into master (45e4cc1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2433   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          185       185           
  Lines         3292      3292           
  Branches       874       874           
=========================================
  Hits          3292      3292           
Impacted Files Coverage Δ
__dummy__/getExercisesData.ts 100.00% <ø> (ø)

@flacial flacial changed the title fix: Remove nullable field from getExercises query Add required fields to getExercises query Oct 18, 2022
@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Oct 18, 2022 at 11:03PM (UTC)

@flacial flacial merged commit 5ce925f into garageScript:master Oct 18, 2022
@flacial flacial deleted the 3/1990-dojoadmin-manage-exercises-tab branch October 18, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants