Remove full page load link from confirm/[token] page #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
bryanjenningz
commented
Sep 2, 2022
| @@ -16,9 +17,9 @@ const initialValues = { | |||
|
|
|||
| const ConfirmSuccess: React.FC = () => ( | |||
| <Card type="success" title="Password has been set!"> | |||
| <a className="btn btn-primary btn-lg mb-3" role="button" href="/curriculum"> | |||
There was a problem hiding this comment.
It seems like screen readers should view this as a link rather than a button, so I removed role="button".
Codecov Report
@@ Coverage Diff @@
## master #2248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 175 175
Lines 2969 2969
Branches 796 796
=========================================
Hits 2969 2969
|
flacial
approved these changes
Sep 2, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
May you create and link an issue to it ( |
Done |
songz
approved these changes
Sep 2, 2022
SlyBouhafs
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2249
Before this change, there was a link that did a full page load on the confirm password change page (e.g. /confirm/123).
This change removes that full page load link and instead uses the Next.js Link component which improves performance by not doing a full page load (https://nextjs.org/docs/messages/no-html-link-for-pages).
How to test: