-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/markdown toolbar #1013
Feature/markdown toolbar #1013
Conversation
@tomrule007 is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel. @garageScript first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/c0d3/c0d3-app/EmJ9jZ33MW3rkE5vnDN8nSMj2LEL |
Looks great! We already have |
Both packages are tree shaken single svg imports so have both really isnt adding any extra weight to the project physically but does add extra mental burden to the developers so I get not wanting to have both. Feather is missing: Header icon, quote icon and numbered list icon. We are currently only using: Star, CheckCircle, File, Code, GitHub, Linkedin icons from the feather package right now. The GitHub packages has all of those besides the Linkedin icon so we could potential remove feather and just use GitHub icons. |
Yeah bundle size isn't a problem with this, I suggested a single package mostly for a cohesive design, mixing different icon libraries might not look good, so I think a single style of icons across the board when possible would be good regardless of the actual icon library used. |
8dbd623
to
17cdc30
Compare
17cdc30
to
7fb41cb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 141 144 +3
Lines 2263 2419 +156
Branches 559 618 +59
==========================================
+ Hits 2263 2419 +156
|
Updates Issues: #1125, #1010
what
Add markdown buttons to the ` component (the comment input box) with binded hotkeys and tooltips matching those of github.
why
Easy way to style comments and let reviewers know our comment boxes support markdown syntax.
how
Create a custom state type
TextStyle
that lead to small composable functions to build the various style detection functions and apply or remove the style. (More details in #1125)Checklist: