Merge pull request #2651 from flacial/2650-prevent-users-from-setting…

…-an-already-used-username

fix: Prevent users from setting an already used username

graphql/resolvers/userDataCrud.test.js

@@ -18,6 +18,7 @@ describe('User Data CRUD resolvers', () => {
     }
 
     prismaMock.user.update.mockResolvedValueOnce(userMock)
+    prismaMock.user.findFirst.mockResolvedValueOnce(null)
 
     expect(
       updateUserNames(
@@ -27,4 +28,24 @@ describe('User Data CRUD resolvers', () => {
       )
     ).resolves.toStrictEqual(userMock)
   })
+
+  it('Should not update the user username and name if username already used', async () => {
+    expect.assertions(1)
+
+    const userMock = {
+      username: mockUsername,
+      name: mockName
+    }
+
+    prismaMock.user.update.mockResolvedValueOnce(userMock)
+    prismaMock.user.findFirst.mockResolvedValueOnce(userMock)
+
+    expect(
+      updateUserNames(
+        null,
+        { username: mockUsername, mockName },
+        { req: { user: { id: 1 } } }
+      )
+    ).rejects.toEqual(Error('Username is already used'))
+  })
 })

graphql/resolvers/userDataCrud.ts

@@ -9,6 +9,16 @@ export const updateUserNames = withUserContainer<
 >(async (_, args, { req }) => {
   const { username, name } = args
 
+  const usernameAlreadyUsed = await prisma.user.findFirst({
+    where: {
+      username
+    }
+  })
+
+  if (usernameAlreadyUsed) {
+    throw new Error('Username is already used')
+  }
+
   const user = await prisma.user.update({
     where: {
       id: req.user!.id

pages/settings/account/index.tsx

@@ -40,7 +40,8 @@ const BasicSettings = ({
         error={error?.message || ''}
         texts={{
           loading: 'Updating your names...',
-          data: `Updated your names successfully!`
+          data: `Updated your names successfully!`,
+          error: error?.message
         }}
         dismiss={{
           onDismissData: () => {},